Skip to content
Commit 1bcf4092 authored by Sumeyra Demir Kanik's avatar Sumeyra Demir Kanik
Browse files

Extend the metadata test files to include radius yaw pitch

parent 99b5072d
Loading
Loading
Loading
Loading
  • Maintainer

    Hi @demirkanik, we are getting errors in the ISM sanitizer test runs for 2+ objects: https://forge.3gpp.org/rep/ivas-codec-pc/ivas-codec/-/jobs/78442. The logs say: "Error (invalid metadata value provided) while reading ism metadata from: /usr/local/ltv/ltvISM2.csv". I am unfortunately not able to reproduce the failures locally, even after updating this branch. Could you try to reproduce the failure please?

    make clean
    make -j CLANG=1
    ./IVAS_cod -dtx -ism 2 ltvISM1.csv ltvISM2.csv -max_band swb 128000 32 ltv48_2ISM.wav bit
  • Author Developer

    Hey @kiene, I have tried reproducing the error. The first complaint I receive is about the sampling rate:

    Sampling rate mismatch: 32000 Hz requested, but 48000 Hz found in file ./scripts/testv/ltv48_2ISM.wav

    When I ran with 48 I was able to reproduce the error:

    Error (invalid metadata value provided) while reading ism metadata from: ltvISM2.csv

    I am looking into this. Thank you for bringing it up.

  • Author Developer

    @kiene The error is due to the pitch in the last column exceeding the limits [-90, 90] in some of the frames. The way I have extended the metadata files was reusing the azimuth for yaw and elevation for pitch. Since elevation and pitch are defined in the same range, I copied the pitch values from the elevation values of the ltvISM4.csv file. What I do not understand is, if it was not complaining about the ltvISM4.csv in the previous version, why it is complaining now.

    That being said, I will go ahead and check all the files to make sure the defined ranges are met for all.

  • Author Developer

    @kiene I have now fixed the 2 files ltvISM2.csv and ltvISM4.csv for this error in the commit:

    57ffde40

  • Maintainer

    Great, thank you very much for taking care!

  • Jan Kiene @kiene

    mentioned in merge request ivas-codec!594 (merged)

    ·

    mentioned in merge request ivas-codec!594 (merged)

    Toggle commit list
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment