Commit 1baa2069 authored by vaclav's avatar vaclav
Browse files

address reviewers comments

parent e91750be

lib_com/ivas_cnst.h

+9 −9
Original line number Diff line number Diff line
@@ -561,10 +561,10 @@ typedef enum 
#define STEREO_DFT_FLAG_BITS                    1

#define STEREO_DFT_SIDEGAIN_NBITS               5

#define STEREO_DFT_FEC_THRESHOLD                10

#define STEREO_DFT_FEC_THRESHOLD_PLUS_1_INV_Q31 195225786                   /* Q31 */

#define STEREO_DFT_BITDIFF_LP_FAC_Q31           128849019                   /* Low-pass filter coefficient for filtering bit difference between absolute and differential coding, Q31 */ 

#define STEREO_DFT_BITDIFF_ABS_SELECT_Q31       1717986918                  /* Constant to set tendency for selecting absolute coding mode, Q31 */ 

#define STEREO_DFT_BITDIFF_INIT_FX              12288                       /* Init value for low-pass bit difference, 12.0f in Q10*/ 

#define STEREO_DFT_FEC_THRESHOLD_PLUS_1_INV_Q31 ( 195225786 )               /* Q31 */

#define STEREO_DFT_BITDIFF_LP_FAC_Q31           ( 128849019 )               /* Low-pass filter coefficient for filtering bit difference between absolute and differential coding, Q31 */ 

#define STEREO_DFT_BITDIFF_ABS_SELECT_Q31       ( 1717986918 )              /* Constant to set tendency for selecting absolute coding mode, Q31 */ 

#define STEREO_DFT_BITDIFF_INIT_FX              ( 12288 )                   /* Init value for low-pass bit difference, 12.0f in Q10*/ 



#define STEREO_DFT_SIDE_GAIN_NBITS              5

#define STEREO_DFT_IPD_NBITS                    3

lib_com/tcx_utils_fx.c

+3 −2
Original line number Diff line number Diff line
@@ -707,13 +707,14 @@ void lpc2mdct( 


    if ( noInverse )

    {

        /* not used */

        assert( !"not supported option in lpc2mdct()" );

    }

    else

    {

        /* half length FFT */

        scale = add( norm_s( lpcCoeffs[0] ), 1 );

        BASOP_cfft( (cmplx *) ComplexData, FDNS_NPTS, &scale, workBuffer ); /*Q31 - scale*/



        /* Get amplitude */

        j = sub( length, 1 );

        k = 0;

lib_rend/ivas_td_decorr_fx.c

+1 −1
Original line number Diff line number Diff line
@@ -203,7 +203,7 @@ ivas_error ivas_td_decorr_dec_open_fx( 
    ivas_td_decorr_state_t *hTdDecorr_loc;

    ivas_error error;



    buf_len = extract_l( Mpy_32_32( output_Fs, 4294968 ) ); // IVAS_DECORR_PARM_LOOKAHEAD_TAU=2e-3f * 2 ^ 31 -> 4294968

    buf_len = extract_l( Mpy_32_32( output_Fs, 4294968 ) ); // IVAS_DECORR_PARM_LOOKAHEAD_TAU * 2 ^ 31 -> 4294968



    num_out_chans = sub( nchan_internal, 1 );