Commit 3438e2e1 authored by vaillancour's avatar vaillancour
Browse files

Fix to prevent copy of uninit data

parent d3508f9d

lib_com/options.h

+1 −1
Original line number Diff line number Diff line
@@ -89,7 +89,7 @@ 
#define FIX_2252_SCALING_SAVE_HB_SYNTH                  /* VA: issue 2252: fix use-of-uninit-value in save_hb_synth_fx[] scaling in FOA decoding with bitstream that starts with an SID */

#define FIX_2248_EVS_ASSERT                             /* VA: Include _sat in an EVS related part of the code */

#define FIX_2254_IMPROV_COMPLEXITY_BE                   /* VA: BE small complexity reduction  */



#define FIX_2290_COPY_OF_UNINIT_DATA                    /* VA: prevent the copy of un-initialized data */

/* #################### End BE switches ################################## */



/* #################### Start NON-BE switches ############################ */

lib_dec/ivas_core_dec_fx.c

+4 −1
Original line number Diff line number Diff line
@@ -562,8 +562,11 @@ ivas_error ivas_core_dec_fx( 
                hSCE->q_save_hb_synth_fx = Q11;

                move16();

            }



#ifdef FIX_2290_COPY_OF_UNINIT_DATA

            Copy_Scale_sig_16_32_DEPREC( old_syn_12k8_16k_fx_16, old_syn_12k8_16k_fx[n], st->L_frame, Q11 - ( -Q1 ) ); // Q(11 - (-1))

#else

            Copy_Scale_sig_16_32_DEPREC( old_syn_12k8_16k_fx_16, old_syn_12k8_16k_fx[n], L_FRAME16k, Q11 - ( -Q1 ) ); // Q(11 - (-1))

#endif

        }



        Copy_Scale_sig_32_16( st->previoussynth_fx_32, st->previoussynth_fx, L_FRAME48k, 0 ); // Q0