Commit 56f3193b authored by norvell's avatar norvell
Browse files

Port fix NONBE_FIX_1176_OSBA_REVERB_JBM_ASAN_ERROR to address out-of-bounds access

parent e6762a16

lib_com/options.h

+1 −0
Original line number Diff line number Diff line
@@ -122,6 +122,7 @@ 
#define NONBE_1360_LFE_DELAY                           /* Dlb: LFE delay alignment when rendering in CLDFB domain*/

#define NONBE_1229_FIX_ISM1_DPID                        /* Eri: issue 1229: fix bug causing ISM 1 to use default -dpid instead of the specified one */

#define NONBE_SVD_OPTIMIZATION 

#define NONBE_FIX_1176_OSBA_REVERB_JBM_ASAN_ERROR       /* Ericsson: Issue 1176, fix in TDREND_firfilt for subframes shorter than the filter length */



/* #################### End BASOP porting switches ############################ */

lib_rend/ivas_objectRenderer_sfx_fx.c

+7 −2
Original line number Diff line number Diff line
@@ -310,8 +310,13 @@ void TDREND_firfilt_fx( 
    /* Handle memory */

    p_signal_fx = buffer_fx + sub( filterlength, 1 );                        // Qx

    Copy32( mem_fx, buffer_fx, sub( filterlength, 1 ) ); /* Insert memory */ // Qx

#ifdef NONBE_FIX_1176_OSBA_REVERB_JBM_ASAN_ERROR

    Copy32( signal_fx, p_signal_fx, subframe_length ); /* Insert current frame */                                                              // Qx

    Copy32( p_signal_fx + add( sub( subframe_length, filterlength ), 1 ), mem_fx, sub( filterlength, 1 ) ); /* Update memory for next frame */ // Qx

#else

    Copy32( signal_fx, buffer_fx + sub( filterlength, 1 ), subframe_length ); /* Insert current frame */                                     // Qx

    Copy32( signal_fx + add( sub( subframe_length, filterlength ), 1 ), mem_fx, sub( filterlength, 1 ) ); /* Update memory for next frame */ // Qx

#endif



    /* Convolution */

    FOR( i = 0; i < intp_count; i++ )