merge main (7e2bee77) · Commits · SA4 / Audio / IVAS BASOP

lib_com/cldfb_evs_fx.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -996,10 +996,8 @@ ivas_error openCldfb(
		return IVAS_ERROR( IVAS_ERR_FAILED_ALLOC, "Cannot allocate memory for CLDFB" );
		}

		#ifdef FIX_2319_CLDFB_INIT_FLAGS
		hs->flags = 0;
		move16();
		#endif

		hs->type = type;
		move16();

lib_com/gs_noisefill_fx.c

+0 −24

Original line number	Diff line number	Diff line
		@@ -751,19 +751,11 @@ void highband_exc_dct_in_fx(
		test();
		IF( bfi \|\| LT_32( core_brate, 6000 ) \|\| ( LT_32( core_brate, 8600 ) && EQ_16( coder_type, UNVOICED ) ) )
		{
		#ifndef FIX_1478_UNINIT_ON_BFI
		set16_fx( noisepb, 13107, MBANDS_GN ); /0.4 in Q15 /
		#else
		set16_fx( noisepb, 13107, last_bin ); /0.4 in Q15 /
		#endif
		}
		ELSE IF( EQ_16( GSC_IVAS_mode, 3 ) \|\| ( GSC_IVAS_mode > 0 && EQ_16( GSC_noisy_speech, 1 ) ) )
		{
		#ifndef FIX_1478_UNINIT_ON_BFI
		set16_fx( noisepb, 13107 /0.4f/, MBANDS_GN16k );
		#else
		set16_fx( noisepb, 13107 /0.4f/, last_bin );
		#endif
		}
		ELSE
		{
		@@ -780,11 +772,7 @@ void highband_exc_dct_in_fx(
		test();
		IF( GSC_IVAS_mode == 0 && GSC_noisy_speech && !bfi && LE_16( element_mode, IVAS_SCE ) )
		{
		#ifndef FIX_1478_UNINIT_ON_BFI
		set16_fx( noisepb, 3277, MBANDS_GN );
		#else
		set16_fx( noisepb, 3277, last_bin );
		#endif
		}
		test();
		IF( LT_32( core_brate, 6000 ) && LE_16( coder_type, UNVOICED ) )
		@@ -1150,19 +1138,11 @@ void highband_exc_dct_in_ivas_fx(
		test();
		IF( bfi \|\| LT_32( core_brate, 6000 ) \|\| ( LT_32( core_brate, 8600 ) && EQ_16( coder_type, UNVOICED ) ) )
		{
		#ifndef FIX_1478_UNINIT_ON_BFI
		set16_fx( noisepb, 13107, MBANDS_GN ); /0.4 in Q15 /
		#else
		set16_fx( noisepb, 13107, last_bin ); /0.4 in Q15 /
		#endif
		}
		ELSE IF( EQ_16( GSC_IVAS_mode, 3 ) \|\| ( GSC_IVAS_mode > 0 && EQ_16( GSC_noisy_speech, 1 ) ) )
		{
		#ifndef FIX_1478_UNINIT_ON_BFI
		set16_fx( noisepb, 13107 /0.4f/, MBANDS_GN16k );
		#else
		set16_fx( noisepb, 13107 /0.4f/, last_bin );
		#endif
		}
		ELSE
		{
		@@ -1179,11 +1159,7 @@ void highband_exc_dct_in_ivas_fx(

		IF( GSC_IVAS_mode == 0 && GSC_noisy_speech && !bfi && LE_16( element_mode, IVAS_SCE ) )
		{
		#ifndef FIX_1478_UNINIT_ON_BFI
		set16_fx( noisepb, 3277, MBANDS_GN );
		#else
		set16_fx( noisepb, 3277, last_bin );
		#endif
		}

		test();

lib_com/ivas_prot_fx.h

+0 −10

Original line number	Diff line number	Diff line
		@@ -1359,20 +1359,10 @@ void stereo_tcx_init_dec_fx(

		void stereo_icBWE_enc_fx(
		CPE_ENC_HANDLE hCPE, /* i/o: CPE encoder structure */
		#ifdef REMOVE_SCALING_SHB_SPEECH
		const Word16 shb_speech_ref_fx16[], /* i : SHB speech ref channel Q0*/
		Word16 shb_speech_nonref_fx_16[], /* i/o: SHB speech non-ref channel shb_speech_nonref_e*/
		#else
		const Word32 shb_speech_ref_fx[], /* i : SHB speech ref channel */
		const Word16 shb_speech_ref_e, /* i : SHB speech ref channel */
		Word32 shb_speech_nonref_fx[], /* i/o: SHB speech non-ref channel */
		#endif
		Word16 shb_speech_nonref_e, /* i/o: SHB speech non-ref channel */
		#ifdef REMOVE_SCALING_SHB_SPEECH
		const Word16 voice_factors_fx / i : voicing factors Q15 */
		#else
		const Word32 voice_factors_fx / i : voicing factors Q31 */
		#endif
		);

		void initMdctStereoDecData_fx(

lib_com/options.h

+0 −5

Original line number	Diff line number	Diff line
		@@ -81,10 +81,8 @@

		/#define FIX_I4_OL_PITCH/ /* fix open-loop pitch used for EVS core switching */
		#define FIX_1990_SANITIZER_IN_REVERB_LOAD /* Nokia: Fix issue part of issue 1990 by introducing missing free of structure - keep until #2059 is addressed */
		#define FIX_1999_TEMPORARY_DISABLE_DIST_ATT_CHECK /* Eri: Issue 1999: Range check on float values of distance attenuation, while the float values are not propagated to this function. The test is not correct, but configurable distance attenuation is not used in Characterization.*/
		#define TMP_1342_WORKAROUND_DEC_FLUSH_BROKEN_IN_SR /* FhG: Temporary workaround for incorrect implementation of decoder flush with split rendering */
		#define NONBE_1122_KEEP_EVS_MODE_UNCHANGED /* FhG: Disables fix for issue 1122 in EVS mode to keep BE tests green. This switch should be removed once the 1122 fix is added to EVS via a CR. */
		#define FIX_2255_ISAR_RENDER_POSES /* VA: issue 2255: fix missing check in isar_render_poses() */
		#define FIX_1904_HARM_GSC_ENC /* VA: #1904 Harmonization of EVS and IVAS GSC code */
		#define FIX_1478_UNINIT_ON_BFI /* VA: Fix issue 1478 where a vector is partly un-initialized during bfi */
		#define FIX_BASOP_2358_SCALING_OOB /* Eri: Basip issue 2358: Clang-18 reports OOB access where scaling is applied to L_FRAME48k instead of output_frame */
		@@ -117,10 +115,7 @@

		#define FIX_2250_LARGE_DIFFERENCES_BETWEEN_BASOP_AND_FLOAT /* Dolby: Issue 2250: random vector generation in GenShapedSHBExcitation() */
		#define FIX_2338_HARM_GSC_GAIN_COMP /* VA: basop issue 2338: harmonization of band gain computation for both EVS and IVAS */
		#define FIX_BASOP_2317_UNINIT_VALUE_IN_STEREO_CNG /* Eri: Basop issue 2317: Uninitialized value read in case of DTX and BW switching */
		#define FIX_BASOP_2361_OTR /* FhG: Basop issue 2361: Orientation tracking tests for equivalent rotations fail */
		#define FIX_1283_STEREO_DFT_COLLAPSE /* FhG: float issue 1283: fix for critical issue with DFT stereo core coder */
		#define FIX_2379_REMOVE_previoussynth_fx_32 /* VA: basop issue 2379: remove duplicated buffer st->previoussynth_fx_32[] */
		#define FIX_2396_CONSTANT_STRIDE_IN_TC_BUFFER /* FhG/VA: basop issue 2396: keep TC channel pointers in one constant place during decoding and rendering */

		/* ##################### End NON-BE switches ########################### */

lib_com/prot_fx.h

+3 −24

Original line number	Diff line number	Diff line
		@@ -10250,13 +10250,7 @@ void Copy_Scale_sig32(
		void swb_pre_proc_ivas_fx(
		Encoder_State st, / i/o: encoder state structure */
		Word16 new_swb_speech, / o : original input signal at 32kHz - Q0 */
		#ifndef REMOVE_SCALING_SHB_SPEECH
		Word32 new_swb_speech_fx, / o : original input signal at 32kHz - Q - q_reImBuffer */
		#endif
		Word16 shb_speech, / o : SHB target signal (6-14kHz) at 16kHz - Q0*/
		#ifndef REMOVE_SCALING_SHB_SPEECH
		Word16 *Q_shb_spch,
		#endif
		Word32 realBuffer[CLDFB_NO_COL_MAX][CLDFB_NO_CHANNELS_MAX], /* i : real buffer Q - q_reImbuffer */
		Word32 imagBuffer[CLDFB_NO_COL_MAX][CLDFB_NO_CHANNELS_MAX], /* i : imag buffer Q - q_reImbuffer */
		Word16 q_reImBuffer, /* i : scale data of real and imag CLDFB buffers*/
		@@ -10912,21 +10906,6 @@ void bands_and_bit_alloc_ivas_fx(
		const Word16 element_mode, /* i : element mode */
		const Word16 GSC_IVAS_mode /* i : GSC IVAS mode */
		);
		#ifndef FIX_2363_FIND_WSP
		void ivas_find_wsp_fx(
		const Word16 L_frame, /* i : length of the frame Q0*/
		const Word16 L_subfr, /* i : length of subframe Q0*/
		const Word16 nb_subfr, /* i : number of subframes Q0*/
		const Word16 A_fx, / i : A(z) filter coefficients Q12 */
		Word16 Aw_fx, / o : weighted A(z) filter coefficients Q12 */
		const Word16 speech_fx, / i : pointer to the denoised speech frame Q_new */
		const Word16 tilt_fact, /* i : tilt factor Q15 */
		Word16 wsp_fx, / o : poitnter to the weighted speech frame Q_new */
		Word16 mem_wsp_fx, / i/o: W(Z) denominator memory Q_new */
		const Word16 gamma, /* i : weighting factor Q15 */
		const Word16 L_look /* i : look-ahead Q0*/
		);
		#endif

		Word16 RCcontextMapping_encode2_estimate_bandWise_start_fx(
		Word16 x, / Q0 */