Commit a6aacb23 authored by Fabian Bauer's avatar Fabian Bauer
Browse files

fix potential flaws

parent 3b20209c

lib_com/wi_fx.c

+4 −4
Original line number Diff line number Diff line
@@ -4366,15 +4366,15 @@ void copy_phase_fx( DTFS_STRUCTURE *X1_fx, DTFS_STRUCTURE X2_fx, DTFS_STRUCTURE 
        d1l = extract_l( Ltemp_fx );

        Ltemp_fx = L_mult0( X1_fx->b_fx[k], d1l );

#ifdef ISSUE_1836_replace_overflow_libcom__remnant

        Ltemp_fx = L_add_sat( L_shr( Ltemp_fx, 15 ), L_mult( X1_fx->b_fx[k], d1h ) ); /*  sin(w) in Q(q+16+Q-15) */ //??sat

        Ltemp_fx = L_add_sat( L_shr( Ltemp_fx, 15 ), L_mult_sat( X1_fx->b_fx[k], d1h ) ); /*  sin(w) in Q(q+16+Q-15) */ //??sat

        sn = round_fx_sat( L_shl_sat( Ltemp_fx, sub( 30, add( q, X1_fx->Q ) ) ) ); /*  Q15 */                       //??sat //??sat

        retX_fx->b_fx[k] = mult_r( X2_fx.a_fx[k], sn );                                                             /*  X2_fx.Q */

        retX_fx->b_fx[k] = mult_r_sat( X2_fx.a_fx[k], sn );                                                             /*  X2_fx.Q */

        move16();



        Ltemp_fx = L_mult0( X1_fx->a_fx[k], d1l );

        Ltemp_fx = L_add_sat( L_shr( Ltemp_fx, 15 ), L_mult( X1_fx->a_fx[k], d1h ) ); /*  cos(w) in Q(q+Q+1) */ //??sat

        Ltemp_fx = L_add_sat( L_shr( Ltemp_fx, 15 ), L_mult_sat( X1_fx->a_fx[k], d1h ) ); /*  cos(w) in Q(q+Q+1) */ //??sat

        cn = round_fx_sat( L_shl_sat( Ltemp_fx, sub( 30, add( q, X1_fx->Q ) ) ) ); /*  Q15 */                   //??sat //??sat

        retX_fx->a_fx[k] = mult_r( X2_fx.a_fx[k], cn );                                                         /*  X2_fx.Q         */

        retX_fx->a_fx[k] = mult_r_sat( X2_fx.a_fx[k], cn );                                                         /*  X2_fx.Q         */

#else

        Ltemp_fx = L_add_o( L_shr( Ltemp_fx, 15 ), L_mult_o( X1_fx->b_fx[k], d1h, &Overflow ), &Overflow ); /*  sin(w) in Q(q+16+Q-15) */

        sn = round_fx_o( L_shl_o( Ltemp_fx, sub( 30, add( q, X1_fx->Q ) ), &Overflow ), &Overflow );        /*  Q15 */