Unverified Commit bbb4299b authored by norvell's avatar norvell
Browse files

Fixes of a few related comments on Q-values for TD renderer gain

parent f324217e

lib_rend/ivas_objectRenderer_fx.c

+4 −0
Original line number Diff line number Diff line
@@ -665,7 +665,11 @@ ivas_error TDREND_Update_object_positions_fx( 
            {

                return error;

            }

#ifdef FIX_BASOP_2469_OBJ_EDIT_TD_REND_GAIN

            if ( ( error = TDREND_MIX_SRC_SetGain( hBinRendererTd, nS, hIsmMetaData[nS]->gain_fx ) ) != IVAS_ERR_OK )

#else

            if ( ( error = TDREND_MIX_SRC_SetGain( hBinRendererTd, nS, hIsmMetaData[nS]->gain_fx ) ) != IVAS_ERR_OK ) // TODO: Check Gain has correct Q-value

#endif

            {

                return error;

            }

lib_rend/ivas_objectRenderer_sfx_fx.c

+5 −3
Original line number Diff line number Diff line
@@ -280,10 +280,12 @@ void TDREND_firfilt_fx( 
    const Word16 filterlength,     /* i  : Filter length                    Q0 */

#ifdef FIX_BASOP_2469_OBJ_EDIT_TD_REND_GAIN

    const Word32 Gain_fx,    /* i  : Gain                            Q29 */

    const Word32 prevGain_fx /* i  : Previous gain                   Q29 */

#else

    const Word32 Gain_fx,    /* i  : Gain                            Q30 */

#endif

    const Word32 prevGain_fx /* i  : Previous gain                   Q30 */

#endif



)

{

    /* NOTE: this function is implemented with the assumption that the exponent/Q-factor of input signal will not change. */

lib_rend/ivas_objectRenderer_sources_fx.c

+11 −3
Original line number Diff line number Diff line
@@ -139,7 +139,11 @@ ivas_error TDREND_MIX_SRC_SetDir_fx( 
ivas_error TDREND_MIX_SRC_SetGain(

    BINAURAL_TD_OBJECT_RENDERER_HANDLE hBinRendererTd, /* i/o: TD renderer handle   */

    const Word16 SrcInd,                               /* i  : Source index         */

#ifdef FIX_BASOP_2469_OBJ_EDIT_TD_REND_GAIN

    const Word32 Gain /* i  : Gain             Q29 */

#else

    const Word32 Gain /* i  : Gain                 */

#endif

)

{

    TDREND_SRC_SPATIAL_SetGain( hBinRendererTd->Sources[SrcInd], Gain );
@@ -321,7 +325,11 @@ void TDREND_SRC_REND_UpdateFiltersFromSpatialParams_fx( 
    Word16 *intp_count,                                /* o  : Interpolation count                        Q0 */

    Word16 *filterlength,                              /* o  : Length of filters                          Q0 */

    Word16 *itd,                                       /* o  : ITD value                                  Q0 */

#ifdef FIX_BASOP_2469_OBJ_EDIT_TD_REND_GAIN

    Word32 *Gain, /* o  : Gain value                                 Q29 */

#else

    Word32 *Gain, /* o  : Gain value                                 Q30 */

#endif

    TDREND_SRC_t *Src_p /* i/o: Source pointer                            */

)

{