Skip to content

Integration of fixed point sub-functions - 5

Sandesh Venkatesh requested to merge fxd_sub_funcs_integration_5 into main

[x] Integration of fixed point version of ivas_sba_dirac_stereo_dec.
[x] Integrated bandwidth_switching_detect and redundant code removal in ivas_core_dec.
[x] Integration and Cleanup of MASA ISM metadata dec (OMASA path).
[x] Refactor lsf buffers for core_switching_pre_dec().
[x] Integration of few functions for MASA path. Few BASOP and instrumentation changes included.
[x] Functions converted: ivas_qmetadata_azimuth_elevation_to_direction_vector_fx, sort_desc_ind_16_fx, only_reduce_bits_direction_fx.
[x] Added saturation to getCosWord16R2 based on the recommendation from the PC group.
[x] Limitations of only_reduce_bits_direction_fx:\

  • Precision loss was occuring after using BASOP_Util_Divide3232_Scale which was leading to penalty getting calculated wrongly and hence ind_order being sorted incorrectly which might cause infinite loop.\
  • Causing issues for Test OMASA 2Dir2TC 4ISM at 384 kbps, 48kHz in, 48kHz out, EXT out\
  • Workaround is checking if the denominator is same for bits_sph_idx_orig[j] for no_subframes.
    If yes then adding all the numerator first and then doing division later with bits_sph_idx_orig[j][0] instead of dividing each numerator with bits_sph_idx_orig[j][k].

EVS 26.444 test: 3589 passed.

pytests results: 359 failed, 226 passed, 381 skipped.

MLD scores:
Original inputs: (96 cases > 5)
5.003205 5.089962 5.092199 5.102078 5.115001 5.126 5.172749 5.302497 5.331642 5.466336 5.614682 5.688412 5.751117 5.753554 5.940005 5.96871 6.046286 6.06524 6.071974 6.117405 6.138349 6.194695 6.237252 6.29308 6.343643 6.505827 6.550557 6.564048 6.670427 6.672147 6.881684 7.013534 7.21453 7.391822 7.396921 7.51748 7.537398 7.556285 7.768792 7.964099 8.054692 8.085909 8.114678 8.115231 8.123834 8.258634 8.267387 8.755955 8.76778 8.959625 8.994027 8.994027 9.182236 9.196006 9.24835 9.296489 9.366529 9.719712 10.113762 10.141461 10.155926 10.167697 10.287914 10.334426 10.392436 10.82238 10.845243 10.972178 11.46555 11.554901 11.643384 11.643384 11.772644 11.772644 11.787758 11.787758 11.817932 11.890255 12.937432 13.081027 13.506419 13.618318 14.223304 14.933547 15.240928 15.423287 18.090322 18.090322 18.946733 19.355927 19.75568 20.612335 20.612335 20.893738 21.839273 24.899559

+10dB scaled inputs: (189 cases > 5)
5.018706 5.069894 5.121138 5.192748 5.199598 5.263418 5.289392 5.405377 5.417042 5.45025 5.509198 5.518337 5.571427 5.593637 5.677966 5.711199 5.711512 5.766733 5.805526 5.838886 5.881829 5.892097 5.918698 5.923138 5.923138 5.964248 5.972726 5.981004 6.084955 6.09787 6.099187 6.100006 6.121672 6.211931 6.228209 6.304172 6.339276 6.341604 6.375416 6.501565 6.558916 6.587359 6.624967 6.633574 6.72189 6.725737 6.795401 6.798316 6.813084 6.893785 6.953606 7.004622 7.011523 7.06323 7.090879 7.129056 7.14 7.140053 7.159032 7.212332 7.262166 7.304224 7.316517 7.430463 7.488819 7.514463 7.535931 7.540576 7.697215 7.758457 7.758457 7.822741 7.87081 7.990268 7.995438 8.089555 8.101339 8.105639 8.180037 8.368732 8.674395 8.691595 8.691595 8.725204 8.747837 8.771846 8.775548 8.775773 8.906412 8.986109 9.008747 9.053829 9.296819 9.436636 9.536242 9.700128 9.717443 9.754133 9.785027 9.873912 9.873912 9.945329 9.995753 10.055645 10.060358 10.069493 10.07495 10.116163 10.16775 10.173368 10.250774 10.365402 10.426648 10.552432 10.68488 10.948797 11.021714 11.324615 11.347239 11.392046 11.79266 11.863884 11.94757 12.024258 12.100556 12.351682 12.394827 12.676997 12.947269 12.968198 13.016704 13.105254 13.254566 13.258468 13.344253 13.379539 13.618837 13.651038 13.670159 13.723491 13.761937 13.871345 13.903361 13.929139 14.159 14.27398 14.495686 14.519551 14.652344 14.652344 15.116679 15.323384 15.569484 16.921255 16.975588 17.493526 17.506445 17.506445 17.525364 17.56942 17.614422 17.935715 18.130463 19.291277 19.312647 19.314215 19.401911 19.65851 19.65851 19.728577 20.331219 20.388319 20.454504 20.595076 20.704693 20.907349 20.907349 21.248812 21.57069 23.837624 23.875349 24.547428 24.756367 26.422293 28.154564 29.323845 29.605608 35.2337 43.840065

-10dB scaled inputs: (76 cases > 5)
5.040064 5.170506 5.2376 5.237885 5.294276 5.302221 5.434141 5.500454 5.522282 5.669808 5.695507 5.745702 5.80326 5.885917 5.959154 5.963603 6.003563 6.071538 6.117034 6.173225 6.297421 6.346535 6.361089 6.404732 6.404732 6.432162 6.596441 6.630252 6.64332 6.66827 6.725256 6.867795 6.886593 7.045383 7.145298 7.221208 7.320667 7.334984 7.351369 7.372002 7.377677 7.415261 7.435224 7.451896 7.507304 7.621246 7.719276 7.821691 7.914153 7.924033 7.982574 8.072194 8.351258 8.361481 8.985908 9.750897 9.750897 9.917346 10.078553 10.322665 10.58163 11.433108 11.553739 11.820249 11.820249 13.762426 13.762426 15.333611 15.333611 15.623148 15.636178 18.929729 19.146791 20.980843 24.649891 33.147224

Edited by Sandesh Venkatesh

Merge request reports

Loading