Skip to content

[rend-non-BE] [split-non-BE] Fix the float issue 1528 by adding a rendering time resolution independent counter.

Tapani Pihlajakujarequested to merge
float-1528-ivas_rend-ism-rendering-not-working-correctly-for-omasa-input-with-5-ms-output into main

Reason why this change is needed

  • The ISM metadata update in 5 ms rendering path is not working correctly when there is any metadata delay needed. This happens, for example, with OMASA input where sync delay of one subframe is needed to match signals between MASA and ISM parts. In practice, update never happens if the delay is larger than the rendering subframe count goes through within ivas_td_binaural_renderer_unwrap.

Description of the change

  • An independent counter is added within TDREND_WRAPPER which is then updated every rendered subframe. This makes the update independent of the rendering resolution although only allows still at most 3 subframes of delay.
  • The solution removes const qualification from input_ism and the wrapper but this seemed to be the minimal change approach that would be guaranteed to work even with varying number of wrappers in split rendering.

Affected operating points

  • Only IVAS_rend affected. Non-BE for 5 ms rendering where ISM metadata delay is needed. Would be also non-BE for 10 ms rendering if a long enough delay is requested. In test set, mainly OMASA rendering should be currently affected.
  • Also corresponding split rendering cases are expected to be affected.

Merge request reports