Resolve "[Regression2553] Basop assert in OMASA encoder inside NONBE_FIX_ISSUE_2206_SWB_EXPERIMENT"
- Related issues: 2527
- Requested reviewers: @vaillancour
Reason why this change is needed
- In case of ACELP_24k40 the buffer hBWE_TD->shb_inv_filt_mem_fx is used to extrapolate a signal, and needs to be brought to the same scale as shb_frame. The scale operation can overflow in some cases, and this leads to a crash.
Description of the change
- The scale operation which overflowed was changed to saturating Scale_sig(). The impact of this saturation is low and seldom, on the contrary changing the scale of shb_frame would require a very big structural change with very little improvement.
Affected operating points
python3 scripts/runIvasCodec.py -p scripts/config/ci_linux_ltv.json -m OMASA_ISM2_2TC_b32_swb_cbr --oc EXT -o out
IVAS_cod -ism_masa 2 2 ltv/ltv48_OMASA_2ISM_2TC_ISM1.csv ltv/ltv48_OMASA_2ISM_2TC_ISM2.csv ltv/ltv48_OMASA_2ISM_2TC.met -max_band swb 32000 32 ltv/ltv48_OMASA_2ISM_2TC_32_OMASA_ISM2_2TC.pcm out.192
Closes #2527 (closed)
Edited by Manuel Jander