[rend-non-BE] Resolve "MASA rendering via DirAC renderer in IVAS_rend has several issues in BASOP conversion"

Tapani Pihlajakujarequested to merge
basop-2571-masa-rendering-via-dirac-renderer-in-ivas_rend-has-several-issues-in-basop-conversion into main
  • Related issues: #2571
  • Requested reviewers: FhG

Reason why this change is needed

  • As stated in the issue, The MASA ext renderer BASOP conversion has had many errors (and still has) and is unnecessarily deviating from the approach in decoder.

Description of the change

  • Removal of MASA EXT renderer specific function intermidiate_ext_dirac_render() which already was kind of patchwork.
  • Removal of unnecessary and occasionally wrong scaling/Q-state setting
  • Copying and adapting (largely reducing) from decoder function ivas_dirac_dec_render_sf_fx() the preprocessing section for state maintenance
  • Fix double Q-adjustment in reference_power_smooth
  • Copy also pre-subframe processing scaling for gains and diffuse buffer.
  • Adds missing stereo_type_detect accumulator init (which for some reason is in different place in BASOP and float)

Affected operating points

  • Renderer only
  • Affects MASA and OMASA when using DIRAC_RENDERER (MONO/FOA/HOA/LS)
  • Mostly small effects in test vectors but LTV shows for some cases around 1 MLD improvements.

Closes #2571

Edited by Tapani Pihlajakuja

Merge request reports