Skip to content

Add missing rescaling of mem_syn2_fx and mem_deemph_fx in case of HQ-ACELP switch

norvell requested to merge 906-lf-discontinuity-when-going-from-hq-core-to-acelp-core into main

Closes #906 (closed)

Transitions from HQ to ACELP is done by using the past HQ synthesis to populate

  • excitation memory
  • synthesis filter memory
  • preemphasis filter memory

For the last two, the scaling was missing. The data is stored in Q0 and needs to be rescaled to Q_syn.

The issue is filed by @vaillancour, but he is currently away. The minimal cross-check would be to look at the code and run the decoder with the bit for the problematic bit stream in #906 (closed). @vaclav, would you have the time to check this?

The command line using a shortened bitstream (cut from the longer bitstream in #906 (closed)) is:

IVAS_dec STEREO 48 test.bit out.wav

test.bit

Merge request reports