Commit 3efd7725 authored by vaclav's avatar vaclav
Browse files

revision of ToDo comments

parent d55dc76f

lib_com/bits_alloc.c

+2 −2
Original line number Diff line number Diff line
@@ -737,7 +737,7 @@ ivas_error config_acelp1( 
                }

                else /* L_frame == L_FRAME16k */

                {

                    acelp_cfg->lsf_bits = 41; /* TBV: currently LSFQ @16kHz is not flexible (only 31/41 bits supported */

                    acelp_cfg->lsf_bits = 41;

                }

            }
@@ -1360,7 +1360,7 @@ ivas_error config_acelp1( 
                    acelp_cfg->ubits = acelp_cfg->lsf_bits - 46;

                    acelp_cfg->lsf_bits = 46;

                }

                else if ( acelp_cfg->lsf_bits > 42 && L_frame == L_FRAME ) /* TBV: verify maximum supported LSF Q bitbudget (for some reason 43 bits LSFQ decreases segSNR by 0.7 dB) */

                else if ( acelp_cfg->lsf_bits > 42 && L_frame == L_FRAME )

                {

                    acelp_cfg->ubits = acelp_cfg->lsf_bits - 42;

                    acelp_cfg->lsf_bits = 42;

lib_com/gs_bitallocation.c

+1 −1
Original line number Diff line number Diff line
@@ -616,7 +616,7 @@ void bands_and_bit_alloc( 
             * Complete the bit allocation per frequency band for 16kHz high brate mode

             *--------------------------------------------------------------------------*/



            if ( L_frame == L_FRAME16k && core_brate > ACELP_32k ) /* TBV if applicable */

            if ( L_frame == L_FRAME16k && core_brate > ACELP_32k ) /* TODO - TBV if applicable */

            {

                for ( j = st_band; j < nb_bands; j++ )

                {

lib_com/ivas_cnst.h

+2 −2
Original line number Diff line number Diff line
@@ -110,8 +110,8 @@ typedef enum 
    AUDIO_CONFIG_ISM2,                          /* ISM2                         */

    AUDIO_CONFIG_ISM3,                          /* ISM3                         */

    AUDIO_CONFIG_ISM4,                          /* ISM4                         */

    AUDIO_CONFIG_MASA1,                         /* MASA1                        */ // TBV: seems not to be used

    AUDIO_CONFIG_MASA2,                         /* MASA2                        */ // TBV: seems not to be used

    AUDIO_CONFIG_MASA1,                         /* MASA1                        */ // TODO: seems not to be used

    AUDIO_CONFIG_MASA2,                         /* MASA2                        */ // TODO: seems not to be used

    AUDIO_CONFIG_EXTERNAL                       /* external renderer            */



} AUDIO_CONFIG;

lib_com/ivas_pca_tools.c

+1 −1
Original line number Diff line number Diff line
@@ -645,7 +645,7 @@ static void norm_quat( 


    norm_q = dotp( q, q, IVAS_PCA_INTERP );



    norm_q = inv_sqrt( norm_q ); // TBV: possible division by 0

    norm_q = inv_sqrt( norm_q ); // TODO: possible division by 0



    for ( i = 0; i < IVAS_PCA_INTERP; i++ )

    {

lib_dec/acelp_core_dec.c

+2 −2
Original line number Diff line number Diff line
@@ -627,7 +627,7 @@ ivas_error acelp_core_dec( 


                config_acelp1( DEC, st->total_brate, st->core_brate, st->core, st->extl_orig, st->extl_brate_orig, st->L_frame, st->GSC_noisy_speech, &( st->acelp_cfg ), st->next_bit_pos, st->coder_type, tc_subfr_tmp, 1, &nb_bits, unbits, st->element_mode, &uc_two_stage_flag, tdm_lp_reuse_flag, tdm_low_rate_mode, st->idchan, st->active_cnt, tdm_Pitch_reuse_flag, st->tdm_LRTD_flag, st->GSC_IVAS_mode );



                if ( st->coder_type == TRANSITION && tc_subfr < L_SUBFR && st->L_frame == L_FRAME ) /*  ISfm: why is this called again after above */

                if ( st->coder_type == TRANSITION && tc_subfr < L_SUBFR && st->L_frame == L_FRAME )

                {

                    config_acelp1( DEC, st->total_brate, st->core_brate, st->core, st->extl_orig, st->extl_brate_orig, st->L_frame, -1, &( st->acelp_cfg ), st->next_bit_pos, st->coder_type, tc_subfr, 2, &nb_bits, unbits, st->element_mode, &uc_two_stage_flag, tdm_lp_reuse_flag, tdm_low_rate_mode, st->idchan, st->active_cnt, tdm_Pitch_reuse_flag, st->tdm_LRTD_flag, st->GSC_IVAS_mode );

                }
@@ -1090,7 +1090,7 @@ ivas_error acelp_core_dec( 
     * Formant post-filter

     *-----------------------------------------------------------------*/



    if ( st->hPFstat != NULL && st->last_bwidth >= WB && ( st->core_brate > ACELP_24k40 || st->element_mode > EVS_MONO ) && st->core_brate <= ACELP_32k ) /* VE2TV: TBV for TD stereo */

    if ( st->hPFstat != NULL && st->last_bwidth >= WB && ( st->core_brate > ACELP_24k40 || st->element_mode > EVS_MONO ) && st->core_brate <= ACELP_32k ) /* TODO: TBV for TD stereo */

    {

        mvr2r( syn, temp_buf + L_SYN_MEM, L_FRAME16k );