Commit 8d514b63 authored by vaclav's avatar vaclav
Browse files

address comments from BASOP

parent ab5ed9bb

lib_com/edct.c

+3 −38
Original line number Diff line number Diff line
@@ -44,6 +44,7 @@ 
#include "prot.h"

#include "wmc_auto.h"

#include <math.h> /* for cosf, sinf */

#include <assert.h>



static ivas_error get_edct_table(

    const float **edct_table,
@@ -226,7 +227,6 @@ void edst( 
    return;

}



#define FAST_EDXT /* optimized FFT-based DCT/DST algorithm */



/*-------------------------------------------------------------------------*

 * edxt()
@@ -243,9 +243,8 @@ void edxt( 
)

{

    const float pi_len = EVS_PI / length;

    int16_t k, m;

    int16_t k;



#ifdef FAST_EDXT

    if ( kernelType == MDST_II || kernelType == MDCT_II )

    {

        const int16_t Nm1 = length - 1;
@@ -351,42 +350,8 @@ void edxt( 
        }

    }

    else

#endif

        if ( kernelType & 1 ) /* DST */

    {

        const float offK = ( kernelType == MDST_II && synthesis ? 0.5f : 1.0f - 0.5f * ( kernelType >> 1 ) );

        const float offM = ( kernelType == MDST_II && synthesis ? 1.0f : 0.5f );



        for ( k = 0; k < length; k++ )

    {

            y[k] = 0.f;

            for ( m = 0; m < length; m++ )

            {

                y[k] += x[m] * sinf( pi_len * ( m + offM ) * ( k + offK ) );

            }

        }

        if ( offK == 1.f )

        {

            y[length - 1] *= 0.5f; /* scale Nyquist sample */

        }

    }

    else /* kernelType 0, 2: DCT */

    {

        const float offK = ( kernelType == MDCT_II && synthesis ? 0.5f : 0.5f - 0.5f * ( kernelType >> 1 ) );

        const float offM = ( kernelType == MDCT_II && synthesis ? 0.0f : 0.5f );



        for ( k = 0; k < length; k++ )

        {

            y[k] = 0.f;

            for ( m = 0; m < length; m++ )

            {

                y[k] += x[m] * cosf( pi_len * ( m + offM ) * ( k + offK ) );

            }

        }

        if ( offK == 0.f )

        {

            y[0] *= 0.5f; /* scale lowest (i.e. DC) sample */

        }

        assert( !"Unsupported Kernel type in edxt()" );

    }



    v_multc( y, ( kernelType == MDCT_II ? -1.f : 1.f ) * sqrtf( 2.f / length ), y, length );

lib_dec/ivas_init_dec.c

+10 −10
Original line number Diff line number Diff line
@@ -1521,7 +1521,7 @@ ivas_error ivas_init_decoder( 
            return error;

        }



        if ( hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_FOA && st_ivas->hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_STEREO && st_ivas->hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_MONO && !( hDecoderConfig->output_config == IVAS_AUDIO_CONFIG_EXTERNAL && st_ivas->intern_config == IVAS_AUDIO_CONFIG_FOA ) )

        if ( output_config != IVAS_AUDIO_CONFIG_FOA && output_config != IVAS_AUDIO_CONFIG_STEREO && output_config != IVAS_AUDIO_CONFIG_MONO && !( output_config == IVAS_AUDIO_CONFIG_EXTERNAL && st_ivas->intern_config == IVAS_AUDIO_CONFIG_FOA ) )

        {

            if ( ( error = ivas_dirac_dec_config( st_ivas, DIRAC_OPEN ) ) != IVAS_ERR_OK )

            {
@@ -1543,7 +1543,7 @@ ivas_error ivas_init_decoder( 
                st_ivas->hQMetaData->numTwoDirBands = (uint8_t) st_ivas->hQMetaData->q_direction[0].cfg.nbands;

            }



            ivas_dirac_config_bands( band_grouping, IVAS_MAX_NUM_BANDS, (int16_t) ( st_ivas->hDecoderConfig->output_Fs * INV_CLDFB_BANDWIDTH + 0.5f ),

            ivas_dirac_config_bands( band_grouping, IVAS_MAX_NUM_BANDS, (int16_t) ( output_Fs * INV_CLDFB_BANDWIDTH + 0.5f ),

                                     st_ivas->hSpar->dirac_to_spar_md_bands, st_ivas->hQMetaData->useLowerBandRes, st_ivas->hSpar->enc_param_start_band, 0, 1 );

        }

        st_ivas->sba_dirac_stereo_flag = ivas_get_sba_dirac_stereo_flag( st_ivas );
@@ -1668,7 +1668,7 @@ ivas_error ivas_init_decoder( 
            return error;

        }



        if ( hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_FOA && st_ivas->hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_STEREO && st_ivas->hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_MONO )

        if ( output_config != IVAS_AUDIO_CONFIG_FOA && output_config != IVAS_AUDIO_CONFIG_STEREO && output_config != IVAS_AUDIO_CONFIG_MONO )

        {

            if ( ( error = ivas_dirac_dec_config( st_ivas, DIRAC_OPEN ) ) != IVAS_ERR_OK )

            {
@@ -1690,7 +1690,7 @@ ivas_error ivas_init_decoder( 
                st_ivas->hQMetaData->numTwoDirBands = (uint8_t) st_ivas->hQMetaData->q_direction[0].cfg.nbands;

            }



            ivas_dirac_config_bands( band_grouping, IVAS_MAX_NUM_BANDS, (int16_t) ( st_ivas->hDecoderConfig->output_Fs * INV_CLDFB_BANDWIDTH + 0.5f ),

            ivas_dirac_config_bands( band_grouping, IVAS_MAX_NUM_BANDS, (int16_t) ( output_Fs * INV_CLDFB_BANDWIDTH + 0.5f ),

                                     st_ivas->hSpar->dirac_to_spar_md_bands, st_ivas->hQMetaData->useLowerBandRes, st_ivas->hSpar->enc_param_start_band, 0, 1 );

        }
@@ -2127,7 +2127,7 @@ ivas_error ivas_init_decoder( 


        if ( st_ivas->hOutSetup.output_config == IVAS_AUDIO_CONFIG_BINAURAL_ROOM_REVERB )

        {

            if ( ( error = ivas_reverb_open( &st_ivas->hReverb, st_ivas->hHrtfStatistics, st_ivas->hRenderConfig, st_ivas->hDecoderConfig->output_Fs ) ) != IVAS_ERR_OK )

            if ( ( error = ivas_reverb_open( &st_ivas->hReverb, st_ivas->hHrtfStatistics, st_ivas->hRenderConfig, output_Fs ) ) != IVAS_ERR_OK )

            {

                return error;

            }
@@ -2157,8 +2157,8 @@ ivas_error ivas_init_decoder( 
            }

        }



        if ( ( error = ivas_rend_openCrend( &( st_ivas->hCrendWrapper ), st_ivas->intern_config, st_ivas->hDecoderConfig->output_config,

                                            st_ivas->hRenderConfig, st_ivas->hHrtfCrend, st_ivas->hHrtfStatistics, st_ivas->hDecoderConfig->output_Fs, 0, ( st_ivas->hSplitBinRend == NULL ) ? 1 : st_ivas->hSplitBinRend->splitrend.multiBinPoseData.num_poses ) ) != IVAS_ERR_OK )

        if ( ( error = ivas_rend_openCrend( &( st_ivas->hCrendWrapper ), st_ivas->intern_config, output_config,

                                            st_ivas->hRenderConfig, st_ivas->hHrtfCrend, st_ivas->hHrtfStatistics, output_Fs, 0, ( st_ivas->hSplitBinRend == NULL ) ? 1 : st_ivas->hSplitBinRend->splitrend.multiBinPoseData.num_poses ) ) != IVAS_ERR_OK )

        {

            return error;

        }
@@ -2260,7 +2260,7 @@ ivas_error ivas_init_decoder( 


            if ( st_ivas->hOutSetup.output_config == IVAS_AUDIO_CONFIG_BINAURAL_ROOM_REVERB )

            {

                if ( ( error = ivas_reverb_open( &st_ivas->hReverb, st_ivas->hHrtfStatistics, st_ivas->hRenderConfig, st_ivas->hDecoderConfig->output_Fs ) ) != IVAS_ERR_OK )

                if ( ( error = ivas_reverb_open( &st_ivas->hReverb, st_ivas->hHrtfStatistics, st_ivas->hRenderConfig, output_Fs ) ) != IVAS_ERR_OK )

                {

                    return error;

                }
@@ -2323,7 +2323,7 @@ ivas_error ivas_init_decoder( 
        {

            if ( st_ivas->hBinRenderer->render_lfe )

            {

                if ( st_ivas->hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_CODED && st_ivas->hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_PCM )

                if ( output_config != IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_CODED && output_config != IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_PCM )

                {

                    /* Account for filterbank delay */

                    delay_ns += IVAS_FB_DEC_DELAY_NS;
@@ -2378,7 +2378,7 @@ ivas_error ivas_init_decoder( 


    if ( ( st_ivas->ivas_format == MASA_FORMAT || st_ivas->ivas_format == MASA_ISM_FORMAT ) && hDecoderConfig->Opt_tsm )

    {

        if ( st_ivas->hDecoderConfig->output_config == IVAS_AUDIO_CONFIG_EXTERNAL )

        if ( output_config == IVAS_AUDIO_CONFIG_EXTERNAL )

        {

            if ( ( error = ivas_jbm_dec_metadata_open( st_ivas ) ) != IVAS_ERR_OK )

            {

lib_enc/ivas_init_enc.c

+1 −1
Original line number Diff line number Diff line
@@ -782,7 +782,7 @@ ivas_error ivas_init_encoder( 
    {

        st_ivas->mc_mode = ivas_mc_mode_select( hEncoderConfig->mc_input_setup, ivas_total_brate );



        if ( ( error = ivas_create_lfe_lpf_enc( &st_ivas->hLfeLpf, hEncoderConfig->input_Fs ) ) != IVAS_ERR_OK )

        if ( ( error = ivas_create_lfe_lpf_enc( &st_ivas->hLfeLpf, input_Fs ) ) != IVAS_ERR_OK )

        {

            return error;

        }