Commit e4226ae3 authored by norvell's avatar norvell
Browse files

Merge branch '406-listener-position-structure' into 'main' 

Replace IVAS_POSITION with IVAS_VECTOR3 under FIX_406_IVAS_POSITION

See merge request !561
parents 107d150c fdb99bcb

apps/decoder.c

+4 −0
Original line number Diff line number Diff line
@@ -1429,7 +1429,11 @@ static ivas_error decodeG192( 
    ivas_error error = IVAS_ERR_UNKNOWN;

    uint16_t numObj = 0;

    IVAS_DEC_BS_FORMAT bsFormat = IVAS_DEC_BS_UNKOWN;

#ifdef FIX_406_IVAS_POSITION

    IVAS_VECTOR3 Pos[IVAS_MAX_PARAM_SPATIAL_SUBFRAMES];

#else

    IVAS_POSITION Pos[IVAS_MAX_PARAM_SPATIAL_SUBFRAMES];

#endif



    IsmFileWriter *ismWriters[IVAS_MAX_NUM_OBJECTS];

    for ( i = 0; i < IVAS_MAX_NUM_OBJECTS; ++i )

apps/renderer.c

+4 −0
Original line number Diff line number Diff line
@@ -536,7 +536,11 @@ int main( 
    int32_t delayTimeScale = 0;

    int16_t i, numChannels;

    ivas_error error = IVAS_ERR_OK;

#ifdef FIX_406_IVAS_POSITION

    IVAS_VECTOR3 Pos[RENDERER_HEAD_POSITIONS_PER_FRAME];

#else

    IVAS_POSITION Pos[RENDERER_HEAD_POSITIONS_PER_FRAME];

#endif



#ifdef WMOPS

    reset_wmops();

lib_com/common_api_types.h

+2 −0
Original line number Diff line number Diff line
@@ -93,11 +93,13 @@ typedef struct 
    float x, y, z;

} IVAS_VECTOR3;



#ifndef FIX_406_IVAS_POSITION

typedef struct

{

    float x, y, z;



} IVAS_POSITION;

#endif



typedef struct ivas_masa_metadata_frame_struct *IVAS_MASA_METADATA_HANDLE;

#ifdef FIX_350_MASA_DELAY_COMP

lib_com/options.h

+1 −0
Original line number Diff line number Diff line
@@ -170,6 +170,7 @@ 
#define ISSUE_24_CLEANUP_MCT_LFE                        /* Issue 24: Cleanup LFE path withing MCT */ 



#define FIX_401_DIRAC_RENDERER_META_READ_INDICES        /* Nokia: Issue 401: Fix metadata reading indices in DirAC renderer. */

#define FIX_406_IVAS_POSITION                           /* Eri: Issue 406: Unify IVAS_POSITION to use IVAS_VECTOR3 instead */



/* ################## End DEVELOPMENT switches ######################### */

/* clang-format on */

lib_dec/lib_dec.c

+5 −1
Original line number Diff line number Diff line
@@ -895,7 +895,11 @@ ivas_error IVAS_DEC_GetMasaMetadata( 
ivas_error IVAS_DEC_FeedHeadTrackData(

    IVAS_DEC_HANDLE hIvasDec,     /* i/o: IVAS decoder handle                        */

    IVAS_QUATERNION *orientation, /* i  : head-tracking data, listener orientation   */

#ifdef FIX_406_IVAS_POSITION

    IVAS_VECTOR3 *Pos /* i  : listener position                          */

#else

    IVAS_POSITION *Pos /* i  : listener position                          */

#endif

)

{

    HEAD_TRACK_DATA_HANDLE hHeadTrackData;