Skip to content

Remove some deactivated #if 0 code in split rendering and SBA

Basic Info

Reason why this change is needed

As an extension of Issue #451 (closed) , I created this ticket to list some deactivated code that should be reviewed and/or reviewed. I will tag the people I think should have a look, please pass it on to someone else if you do not feel responsible.

  • lib_com/basop_util.c 1088,1: #if 0 /* original version creates an overflow warning */ @doehla
  • lib_dec/ivas_dirac_dec.c 2094,1: #if 0 @bayers
  • lib_dec/ivas_spar_md_dec.c 677,1: #if 0 @weckbecker
  • lib_enc/ivas_spar_encoder.c 886,1: #if 0 /* SBA_TD_RESIDUAL */ @mundth

Newly introduced instances:

  • \lib_dec\ivas_output_config.c(266):#if 0 // def DEBUGGING /temp disabling this as paramMC crashes with CREND/
  • \lib_enc\lib_enc.c(1922):#if 0 // IVAS_fmToDo: temporary disabled to keep EVS bit-exactness -> to be verified
  • \lib_rend\ivas_PredEncoder.c(269):#if 0
  • \ivas-codec\lib_rend\ivas_splitRend_lcld_enc.c(172):#if 0
  • \ivas-codec\lib_rend\ivas_splitRenderer_utils.c(274):#if 0
  • \ivas-codec\lib_rend\ivas_splitRendererPost.c(1096):#if 0 (DLB: KEEP FOR NOW)
  • \ivas-codec\lib_rend\ivas_splitRendererPost.c(1262):#if 0 (DLB: KEEP FOR NOW)
  • \ivas-codec\lib_rend\ivas_splitRendererPre.c(626):#if 0 (DLB: KEEP FOR NOW)
  • \ivas-codec\lib_rend\ivas_splitRendererPre.c(633):#if 0 (DLB: KEEP FOR NOW)
  • \lib_rend\ivas_splitRendererPre.c(1436):#if 0 (DLB: KEEP FOR NOW)
  • \ivas-codec\lib_rend\ivas_splitRendererPre.c(1462):#if 0 (DLB: KEEP FOR NOW)
  • \lib_debug\sba_debug.c(205):#if 0

Description of the change

  • Removes the #if 0 from sba and split rendering code.

Affected operating points

  • BE for bitstream and audio output.
Edited by Adam Mills

Merge request reports

Loading