Skip to content

[CI] Test clipping

norvell requested to merge ci/test-clipping into main

Reason why this change is needed

  • This updates the scripts to be able to record the output of the check_clipping function for the SCE/CPE encoder input and put it in the xml report as properties. Then the updates to the parse_xml_report.py allows to add this to the csv report, if the argument --clipping is given.
  • Simplifies measuring the impact of the down-mix scaling changes. The additions under DEBUGGING would need to be ported to the branch to be tested, e.g. the ivas-float-update, with or without the down-mix scaling enabled.

Description of the change

  • Update of the check_clipping function from @vaclav, to also record max/min overload values. Minor corrections to this function.
  • Added parsing of the stdout from the encoder and logging the output with record_property in the xml report.
  • Note: Needs to be compiled with DEBUGGING active to get the output. If no overload is found, the recorded properties will have 0s.
  • Added check-clipping manual job. Not sure we need this, but good to illustrate how it may be used. Could act as template for setting up similar job in the BASOP repo.
  • Edit: Also removes the need to have IVAS_cod and IVAS_dec if you are running update_ref 1.

Affected operating points

  • All tests should work as before.
  • C-code changes under DEBUGGING only
Edited by norvell

Merge request reports

Loading