Skip to content

[Renderer non-BE] fix issue #674 under define FIX_674_MISSING_TABLES_FOR_TDREND_REVERB

kinuthia requested to merge 674-add-missing-tables-used-for-reverb-in-td-renderer-path into main

In the TD renderer path for reverb, rom tables for 32kHz and 16kHz were missing and the precomputed tables for 48kHz were not correct. See #674 (closed).

This branch adds the missing tables and updates the 48kHz rom tables. Reading the tables from binary hrtf files has also been added.

  • add 32kHz and 16kHz rom tables used for reverb in td renderer path
  • update 48kHz tables
  • update generate_tables_from_rom_to_bin.c to write the rom tables to bin
  • update hrtf binaries in scripts/binauralRenderer_interface/binaural_renderers_hrtf_data/ivas_binaural_*.bin
  • read tables from bin if reading hrtf from binary file

The rom total increase is 1542 floats.

On top of fixing this bug the 48,32,16 kHz tables can then be used to significantly reduce rom tables CRendBin_Combined_HRIR_coeff_im_*kHz and CRendBin_Combined_HRIR_coeff_re_*kHz. This will be a seperate ticket.

Merge request reports